On Thu, 26 Oct 2017 14:52:45 -0400 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote:
> The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of this, output > appears in a "stair case" pattern. > > Let's print \r\n on every occurrence of a new line > in the string passed to write to amend this issue. > > This is in sync with the guest Linux code in > drivers/s390/char/sclp_vt220.c which also does a line feed > conversion in the console part of the driver. > > This fixes the s390-ccw and s390-netboot output like > $ virsh start test --console > Domain test started > Connected to domain test > Escape character is ^] > Network boot starting... > Using MAC address: 02:01:02:03:04:05 > Requesting > information via DHCP: 010 > > Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> I'm a bit confused about that s-o-b chain... where does Christian come in here? [Nothing further from me about the actual code change.] > --- > pc-bios/s390-ccw/sclp.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-)