On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > -        if (!discard) {
> > +        if (discard) {
> > +            goto next;
> > +        }
> 
> > +    next:
> >          virtqueue_push(vq, &elem, 0);
> 
> Please don't do this.

Could you elaborate?

I can move the 'discard' check into the following 'for' loop, but since
the value of discard doesn't change, I moved it outside.

                Amit

Reply via email to