On Mon, Oct 30, 2017 at 4:00 PM, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > On 27/10/17 17:42, Philippe Mathieu-Daudé wrote: [...] >> If you don't accept my comments (or don't have time) about keeping >> "hw/sparc/sparc32_dma.h" generic and moving network/scsi parts in >> "hw/sparc/sun4m.h" you can still add to your series: >> >> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Thanks for the review, I've added your R-B tags to the individual > patches. Note that while potentially I could move the network/scsi parts > to hw/sparc/sun4m.h I feel that it's a slightly better match for the > SPARC32 DMA container device to remain in sparc32_dma.c. So for these > patches I've just added your A-B tag.
OK. >> Also while testing your series on a Debian image, I noted your series >> results faster, I timed: >> >> master: 104s >> your series: 85s (>20% faster!) > > Really? Is that for just this patchset or also with the v2 IOMMU > patchset applied on top? I can't immediately see how moving the logic > into sparc32_dma.c could make a difference here... Yes, I was trying with both series applied, so this comment belong to the other series (IOMMU). Regards, Phil.