在 2017/11/8 3:35, Eric Blake 写道:
On 11/07/2017 05:00 AM, QingFeng Hao wrote:
+
+##
+# @GuestPanicInformationS390:
+#
+# S390 specific guest panic information (PSW)
+#
+# Since: 2.11
+##
+{'struct': 'GuestPanicInformationS390',
+ 'data': { 'psw-mask': 'uint64',
+ 'psw-addr': 'uint64',
+ 'reason': 'str' } }
Missing documentation of the three fields; in particular, whether
I didn't get your point, do you mean we need to add comments
for the three fields? But I don't see the comments for Hyper-V either.
Your mailer is eating blank lines, which makes it harder to visually
distinguish where quoting ends and where new content begins (I had a
blank line between your "'reason': 'str' } }" content and my "Missing
documentation..." comment).
Sorry about that I am using thunderbird and I had set some related
configurations
but not sure what's going on. I can read it normally.
I mean something like:
##
# @GuestPanicInformationS390:
#
# S390 specific guest panic information (PSW)
#
# @psw-mask: <description of what this mask represents>
# @psw-addr: Address that was accessed to cause the panic
# @reason: Human-readable explanation of the panic (should not be parsed
# by a machine)
#
# Since: 2.11
##
Thanks and our new patch will contain this change.
--
Regards
QingFeng Hao
