On 11/08/2017 06:20 AM, Kevin Wolf wrote: >> Well, they don't only need an explicitly set option, but the important >> point is that they don't work with the default value. But I can add >> something to this effect. > > I'll squash this in if it looks good to you: > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ab96e348e6..76bf50f813 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -3134,8 +3134,11 @@ > # This option is required on the top level of blockdev-add. > # @discard: discard-related options (default: ignore) > # @cache: cache-related options > -# @read-only: whether the block device should be read-only > -# (default: false) > +# @read-only: whether the block device should be read-only (default: > false). > +# Note that some block drivers support only read-only access, > +# either generally or in certain configurations. In this > case, > +# the default value does not work and the option must be > +# specified explicitly.
Yes, that looks reasonable, if we aren't interested in toying with the idea of a per-driver default instead. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature