On 11/08/2017 07:38 PM, Max Reitz wrote: > First of all, test 055 does a valiant job of invoking pause_drive() > sometimes, but that is worth nothing without blkdebug. So the first > thing to do is to sprinkle a couple of "blkdebug::" in there -- with the > exception of the transaction tests, because the blkdebug break points > make the transaction QMP command hang (which is bad). In that case, we > can get away with throttling the block job that it effectively is > paused. > > Then, 055 usually does not pause the drive before starting a block job > that should be cancelled. This means that the backup job might be > completed already before block-job-cancel is invoked; thus making the > test either fail (currently) or moot if cancel_and_wait() ignored this > condition. Fix this by pausing the drive before starting the job. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > tests/qemu-iotests/055 | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
