Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PULL 0/1] slirp update Type: series Message-id: 20171109180142.13923-1-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20171109180142.13923-1-samuel.thiba...@ens-lyon.org -> patchew/20171109180142.13923-1-samuel.thiba...@ens-lyon.org * [new tag] patchew/20171109181741.31318-1-lep...@google.com -> patchew/20171109181741.31318-1-lep...@google.com Switched to a new branch 'test' 9f23f4da08 slirp: don't zero the whole ti_i when m == NULL === OUTPUT BEGIN === Checking PATCH 1/1: slirp: don't zero the whole ti_i when m == NULL... ERROR: code indent should never use tabs #29: FILE: slirp/tcp_subr.c:151: +^I^Iswitch (af) {$ ERROR: code indent should never use tabs #30: FILE: slirp/tcp_subr.c:152: +^I^Icase AF_INET:$ ERROR: code indent should never use tabs #31: FILE: slirp/tcp_subr.c:153: +^I^I ti->ti.ti_i4.ih_x1 = 0;$ ERROR: code indent should never use tabs #32: FILE: slirp/tcp_subr.c:154: +^I^I break;$ ERROR: code indent should never use tabs #33: FILE: slirp/tcp_subr.c:155: +^I^Icase AF_INET6:$ ERROR: code indent should never use tabs #34: FILE: slirp/tcp_subr.c:156: +^I^I ti->ti.ti_i6.ih_x1 = 0;$ ERROR: code indent should never use tabs #35: FILE: slirp/tcp_subr.c:157: +^I^I break;$ ERROR: code indent should never use tabs #36: FILE: slirp/tcp_subr.c:158: +^I^Idefault:$ ERROR: code indent should never use tabs #37: FILE: slirp/tcp_subr.c:159: +^I^I g_assert_not_reached();$ ERROR: code indent should never use tabs #38: FILE: slirp/tcp_subr.c:160: +^I^I}$ total: 10 errors, 0 warnings, 17 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org