On 2017-11-10 19:54, Alberto Garcia wrote: > When you set I/O limits using block_set_io_throttle or the command > line throttling.* options they are kept in the BlockBackend regardless > of whether a BlockDriverState is attached to the backend or not. > > Therefore when removing the limits using blk_io_limits_disable() we > need to check if there's a BDS before attempting to drain it, else it > will crash QEMU. This can be reproduced very easily using HMP: > > (qemu) drive_add 0 if=none,throttling.iops-total=5000 > (qemu) drive_del none0 > > Reported-by: sochin jiang <sochin.ji...@huawei.com> > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > block/block-backend.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
