On Thu, Nov 9, 2017 at 5:54 PM, Cédric Le Goater <c...@kaod.org> wrote: > On 11/08/2017 04:24 AM, Joel Stanley wrote:
>> --- a/hw/misc/aspeed_sdmc.c >> +++ b/hw/misc/aspeed_sdmc.c >> @@ -18,7 +18,6 @@ >> >> /* Protection Key Register */ >> #define R_PROT (0x00 / 4) >> -#define PROT_KEY_UNLOCK 0xFC600309 > > why are you using the memory controller magic value ? Oh. My bad. I think both ctags and myself became confused :) >> --- a/include/hw/misc/aspeed_sdmc.h >> +++ b/include/hw/misc/aspeed_sdmc.h >> @@ -16,6 +16,8 @@ >> >> #define ASPEED_SDMC_NR_REGS (0x8 >> 2) >> >> +#define PROT_KEY_UNLOCK 0xFC600309 > > Ditto. Should we be using the one from SCU ? > > Now that we are externalizing this value, adding a prefix would be > preferable : ASPEED_SCU_ ? I will grab the correct value from the SCU and rename it ASPEED_SCU_PROT_KEY for v2. Thanks for taking a look. Cheers, Joel