On 11/10/2017 10:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.11.2017 19:06, Eric Blake wrote: >> On 11/09/2017 06:42 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> Interesting fact: list/set_meta_context options are per-export, >>> so, in the server we should keep context selection per client per >>> export. >>> >>> And it is possible for client to set contexts for one export and than >>> proceed >>> to transmission phase with another one. >> However, we also documented in the spec that >> >> + A client MUST NOT send `NBD_CMD_BLOCK_STATUS` unless >> + within the negotiation phase it sent `NBD_OPT_SET_META_CONTEXT` >> + at least once, and the final time it was sent, it referred >> + to the export name that was ultimately selected, the server >> + responded without an error, and returned at least one metadata >> + context. > > I've missed this, then it's OK. > > maybe "ultimately selected for transmission phase" would be a bit better.
Sure, I'll queue that up for my next round of doc tweaks. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
