On Thu, Nov 16, 2017 at 02:29:05PM +0800, Peter Xu wrote:
[...]
> > > > +#
> > > > +# @id: If the original request contains an string-typed "id" field,
> > > > +# it'll be put into this field. Otherwise it'll be an empty
> > > > +# string.
> > >
> > > Please change:
> > >
> > > @id: The dropped command's string-typed "id" field.
> >
> > Ok.
>
> I just found this one tricky: currently we allow all kinds of "id"
> fields in QMP commands, which means that here I should allow all kinds
> of "id" fields as well rather than restrict it as "string" typed.
>
> But I don't really know how to do that in QMP, say, what I want is
> something like:
>
> { 'event': 'REQUEST_DROPPED' ,
> 'data': { 'id': 'object', 'reason': 'RequestDropReason' } }
> ^^^^^^^^
>
> Any thoughts on how to do that the simple way?
Please ignore it. I just noticed that we have type 'any' which I can
use. Sorry for the noise.
--
Peter Xu
