On 20.11.2017 04:44, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PULL 0/6] Net patches > Type: series > Message-id: 1511148687-24909-1-git-send-email-jasow...@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > t [tag update] > patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk -> > patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk > * [new tag] > patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com -> > patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com > Switched to a new branch 'test' > 6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too > e3b7d3045b net: Transmit zero UDP checksum as 0xFFFF > 528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation > 434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts > c2e0b52dd7 Revert "Add new PCI ID for i82559a" > 3e70742c2d colo-compare: fix the dangerous assignment > > === OUTPUT BEGIN === > Checking PATCH 1/6: colo-compare: fix the dangerous assignment... > Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"... > Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian > hosts... > Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation... > Checking PATCH 5/6: net: Transmit zero UDP checksum as 0xFFFF... > Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts, > too... > ERROR: spaces required around that ':' (ctx:VxV) > #237: FILE: hw/net/vmxnet3.h:232: > + u32 msscof:14; /* MSS, checksum offset, flags */ > ^ > > ERROR: spaces required around that ':' (ctx:VxV) > #238: FILE: hw/net/vmxnet3.h:233: > + u32 ext1:1; > ^
Just for the records (again): These errors seem to be false positives from checkpatch. I originally tried to add spaces to all changed bitfields, but then checkpatch suddenly complains that spaces are not allowed there... Thomas
