On Sun, Nov 19, 2017 at 11:18:55PM -0800, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH] spapr: Implement bug in spapr-vty device to be > compatible with PowerVM > Type: series > Message-id: 20171120071423.11693-1-da...@gibson.dropbear.id.au > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/20171120071423.11693-1-da...@gibson.dropbear.id.au -> > patchew/20171120071423.11693-1-da...@gibson.dropbear.id.au > Switched to a new branch 'test' > 08e9d8fe82 spapr: Implement bug in spapr-vty device to be compatible with > PowerVM > > === OUTPUT BEGIN === > Checking PATCH 1/1: spapr: Implement bug in spapr-vty device to be compatible > with PowerVM... > ERROR: spaces required around that '-' (ctx:VxV) > #40: FILE: hw/char/spapr_vty.c:68: > + if (buf[n-1] == '\r') {
I've corrected this in my tree. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature