On Fri, 8 Dec 2017 13:19:27 +0000 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 8 December 2017 at 13:16, Igor Mammedov <imamm...@redhat.com> wrote: > > TBH: > > I do not recall why we have x86 max/host cpu types do feature > > loading at realize time instead of at class init like the rest > > of static cpu types. > > class init is too early, IIRC -- it's before KVM has been set up at all. that shouldn't be an issue as kvm_ppc_register_host_cpu_type() demonstrates (i.e. an additional class init at kvm/tcg init time), so it might be some compat issue or just legacy approach why it havn't been rewritten to class_init for x86 the way PPC does. But Eduardo probably knows better if there is anything left that prevents using class init there. > > thanks > -- PMM
