Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20171210195931.26042-1-programmingk...@gmail.com
Subject: [Qemu-devel] [PATCH] Add ability for user to specify mouse ungrab key
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
27712d6200 Add ability for user to specify mouse ungrab key
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Add ability for user to specify mouse ungrab key...
ERROR: if this code is redundant consider removing it
#115: FILE: vl.c:3113:
+#if 0 /* remove this once these function keys are defined */
ERROR: externs should be avoided in .c files
#157: FILE: vl.c:3155:
+int get_ungrab_key_value(void);
total: 2 errors, 0 warnings, 151 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
