On 14/12/2017 19:40, Philippe Mathieu-Daudé wrote:
>>> + DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState,
>>> pending_insert_quirk,
>>> + false),
>> I like the reduction of code in this patch, but aren't we now going to
>> have device properties that aren't actually connected to anything?
> I'm not sure I understand, ar you worried about the PCI_SDHCI will now
> have this property but not use it?
>
> I couldn't find any machine using SDHCI via PCI and was tempted to
> just remove this code,
PCI devices can be created with -device, they don't have to be added by
boards.
Paolo
