Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 1513790098-9815-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/46] First batch of misc patches for QEMU 2.12 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 784f1d412c chardev: convert the socket server to QIONetListener 913bc4b43c blockdev: convert qemu-nbd server to QIONetListener c5312f02ce blockdev: convert internal NBD server to QIONetListener 8ea4a652ea test: add some chardev mux event tests d08cc74e88 chardev: fix backend events regression with mux chardev d2b264495b rcu: reduce more than 7MB heap memory by malloc_trim() fcef1c98fa checkpatch: volatile with a comment or sig_atomic_t is okay 1db2303fc0 i8259: move TYPE_INTERRUPT_STATS_PROVIDER upper 30e06e33bf kvm-i8259: support "info pic" and "info irq" 57a7117c3a i8259: generalize statistics into common code 22e865ea7e i8259: use DEBUG_IRQ_COUNT always cb30f9bb23 i8259: convert DPRINTFs into trace de0e3bc778 Remove legacy -no-kvm-pit option c88841bd2d scsi: replace hex constants with #defines 1e1c54f23f scsi: provide general-purpose functions to manage sense data 3c107012a2 hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP 24c0e08084 hw/mips/boston: Remove workaround for writes to ROM aborting 5209850f2c exec: Don't reuse unassigned_mem_ops for io_mem_rom 1deadef1c3 block/iscsi: only report an iSCSI Failure if we don't handle it gracefully 400e06269d block/iscsi: dont leave allocmap in an invalid state on UNMAP failure a1303221a4 cpu: suffix cpu address spaces with cpu index 0628ef1b41 cpu: refactor cpu_address_space_init() d1c1216812 tests/boot-serial-test: Add support for the raspi2 machine cf3a5ef594 tests/boot-serial-test: Add a test for the moxiesim machine 5d14a211cb hw/moxie/moxiesim: Add support for loading a BIOS on moxiesim 731d666321 tests/boot-serial-test: Add tests for microblaze boards 6877647e58 tests/boot-serial-test: Add support for the mcf5208evb board 78e93db470 tests/boot-serial-test: Add code to allow to specify our own kernel or bios d07f10209a tests/boot-serial-test: Make sure that we check the timeout regularly fbbc2322b9 target/i386: Fix handling of VEX prefixes 2885eac109 sockets: remove obsolete code that updated listen address 6549fd19a9 baum: Truncate braille device size to 84x1 9a9c369e13 target/i386: Fix compiler warnings c8783cefce cpu-exec: fix missed CPU kick during interrupt injection 9d3f7299bc cpus: make pause_all_cpus() play with SMP on single threaded TCG 2e77bcf01f hyperv: make SynIC version msr constant 1ffad6d1f7 hyperv: ensure SINTx msrs are reset properly 930f81a089 hyperv: set partition-wide MSRs only on first vcpu c948257a80 x86/cpu: Enable new SSE/AVX/AVX512 cpu features 6b2ad070e1 MAITAINERS: List Fam Zheng as reviewer for SCSI patches 96948f407b scsi-block: Add share-rw option ea0dc097e6 Revert "docker: Enable features explicitly in test-full" d3dbc385ac contrib: add systemd unit files fa1ad0e290 qemu-pr-helper: miscellaneous fixes 0d358f6451 qemu-thread: fix races on threads that exit very quickly d7c8a0c55d memfd: fix configure test === OUTPUT BEGIN === Checking PATCH 1/46: memfd: fix configure test... Checking PATCH 2/46: qemu-thread: fix races on threads that exit very quickly... ERROR: braces {} are necessary for all arms of this statement #131: FILE: util/qemu-thread-posix.c:544: + if (err) [...] total: 1 errors, 0 warnings, 86 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/46: qemu-pr-helper: miscellaneous fixes... Checking PATCH 4/46: contrib: add systemd unit files... Checking PATCH 5/46: Revert "docker: Enable features explicitly in test-full"... Checking PATCH 6/46: scsi-block: Add share-rw option... Checking PATCH 7/46: MAITAINERS: List Fam Zheng as reviewer for SCSI patches... Checking PATCH 8/46: x86/cpu: Enable new SSE/AVX/AVX512 cpu features... Checking PATCH 9/46: hyperv: set partition-wide MSRs only on first vcpu... Checking PATCH 10/46: hyperv: ensure SINTx msrs are reset properly... Checking PATCH 11/46: hyperv: make SynIC version msr constant... Checking PATCH 12/46: cpus: make pause_all_cpus() play with SMP on single threaded TCG... Checking PATCH 13/46: cpu-exec: fix missed CPU kick during interrupt injection... Checking PATCH 14/46: target/i386: Fix compiler warnings... Checking PATCH 15/46: baum: Truncate braille device size to 84x1... Checking PATCH 16/46: sockets: remove obsolete code that updated listen address... Checking PATCH 17/46: target/i386: Fix handling of VEX prefixes... Checking PATCH 18/46: tests/boot-serial-test: Make sure that we check the timeout regularly... Checking PATCH 19/46: tests/boot-serial-test: Add code to allow to specify our own kernel or bios... Checking PATCH 20/46: tests/boot-serial-test: Add support for the mcf5208evb board... Checking PATCH 21/46: tests/boot-serial-test: Add tests for microblaze boards... Checking PATCH 22/46: hw/moxie/moxiesim: Add support for loading a BIOS on moxiesim... Checking PATCH 23/46: tests/boot-serial-test: Add a test for the moxiesim machine... Checking PATCH 24/46: tests/boot-serial-test: Add support for the raspi2 machine... Checking PATCH 25/46: cpu: refactor cpu_address_space_init()... Checking PATCH 26/46: cpu: suffix cpu address spaces with cpu index... Checking PATCH 27/46: block/iscsi: dont leave allocmap in an invalid state on UNMAP failure... Checking PATCH 28/46: block/iscsi: only report an iSCSI Failure if we don't handle it gracefully... Checking PATCH 29/46: exec: Don't reuse unassigned_mem_ops for io_mem_rom... Checking PATCH 30/46: hw/mips/boston: Remove workaround for writes to ROM aborting... Checking PATCH 31/46: hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP... Checking PATCH 32/46: scsi: provide general-purpose functions to manage sense data... Checking PATCH 33/46: scsi: replace hex constants with #defines... Checking PATCH 34/46: Remove legacy -no-kvm-pit option... Checking PATCH 35/46: i8259: convert DPRINTFs into trace... Checking PATCH 36/46: i8259: use DEBUG_IRQ_COUNT always... Checking PATCH 37/46: i8259: generalize statistics into common code... Checking PATCH 38/46: kvm-i8259: support "info pic" and "info irq"... Checking PATCH 39/46: i8259: move TYPE_INTERRUPT_STATS_PROVIDER upper... Checking PATCH 40/46: checkpatch: volatile with a comment or sig_atomic_t is okay... ERROR: line over 90 characters #35: FILE: scripts/checkpatch.pl:2481: + my $msg = "Use of volatile is usually wrong, please add a comment\n" . $herecurr; total: 1 errors, 0 warnings, 13 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 41/46: rcu: reduce more than 7MB heap memory by malloc_trim()... Checking PATCH 42/46: chardev: fix backend events regression with mux chardev... Checking PATCH 43/46: test: add some chardev mux event tests... Checking PATCH 44/46: blockdev: convert internal NBD server to QIONetListener... Checking PATCH 45/46: blockdev: convert qemu-nbd server to QIONetListener... Checking PATCH 46/46: chardev: convert the socket server to QIONetListener... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org