Le 21/12/2017 à 21:27, Laurent Vivier a écrit : > Le 21/12/2017 à 20:57, no-re...@patchew.org a écrit : >> Hi, >> >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally. >> >> Type: series >> Message-id: 20171221193640.27418-1-laur...@vivier.eu >> Subject: [Qemu-devel] [PULL 0/5] M68k for 2.12 patches >> > ... >> Configure options: >> --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu >> --prefix=/tmp/qemu-test/install --cross-prefix=x86_64-w64-mingw32- >> --enable-trace-backends=simple --enable-debug --enable-gnutls >> --enable-nettle --enable-curl --enable-vnc --enable-bzip2 >> --enable-guest-agent --with-sdlabi=1.2 --with-gtkabi=2.0 > ... >> /tmp/qemu-test/src/hw/i386/vmport.c: In function 'vmport_ioport_read': >> /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: implicit declaration of >> function 'qemu_log_mask' [-Werror=implicit-function-declaration] >> qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command); >> ^~~~~~~~~~~~~ >> /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: nested extern declaration >> of 'qemu_log_mask' [-Werror=nested-externs] >> /tmp/qemu-test/src/hw/i386/vmport.c:81:23: error: 'LOG_UNIMP' undeclared >> (first use in this function) >> qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command); >> ^~~~~~~~~ >> /tmp/qemu-test/src/hw/i386/vmport.c:81:23: note: each undeclared identifier >> is reported only once for each function it appears in >> cc1: all warnings being treated as errors >> make[1]: *** [hw/i386/vmport.o] Error 1 >> make[1]: *** Waiting for unfinished jobs.... > > Looks like a patch from Paolo's pull is breaking the build: > > commit 7299e1a411de99761a4260e44b4f1cf2e4e126ef > Author: Philippe Mathieu-Daudé <f4...@amsat.org> > Date: Fri Dec 15 00:43:55 2017 -0300 > > hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Message-Id: <20171215034356.4449-2-f4...@amsat.org> > [Replace unknown command tracepoint with LOG_UNIMP, add > generic tracepoint for vmport commands. - Paolo] > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
This is fixed by: diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index 9b8c68806e..116aa09819 100644 --- a/hw/i386/vmport.c +++ b/hw/i386/vmport.c @@ -27,6 +27,7 @@ #include "hw/i386/pc.h" #include "sysemu/hw_accel.h" #include "hw/qdev.h" +#include "qemu/log.h" #include "trace.h" #define VMPORT_CMD_GETVERSION 0x0a Laurent