On 01/08/2018 09:10 AM, Eric Blake wrote: > On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote: > >> Applied, thanks. >> >> PS: just noticed, but "Ed Swierk via Qemu-devel <qemu-devel@nongnu.org>" >> is a bit of an odd Author string to end up in git commit logs, so you >> and/or Ed might like to fix that up for any future patches. >> >> >> Thanks for pointing that out. I wonder if it's happening because I let >> git-send-email automatically fill in the From: line. > > It's also a factor of how strict your ISP is about DMARC handling; the > list automatically rewrites the 'From:' header to insert the 'via > Qemu-devel' tag if it detects DMARC settings at your ISP that won't > allow your email through as originally written. Sadly, mailman doesn't > know to insert a manual 'From:' line in the body when it rewrites the > original From: header; but if you know that DMARC settings are going to > munge your original header, you can probably convince git to always > insert an explicit From: line in the message body to override whatever > munging the list does. >
Hmm - we probably ought to enhance checkpatch.pl to insist that patches attributed to qemu-devel@nongnu.org as the author should be flagged as invalid, since the list munging is a 1:M mapping rather than 1:1, and therefore not easily invertable. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
