On 01/08/2018 11:10 AM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the system /bin/sh is dash. > > Fixes: c97d6d2cdf97ed > Reported-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > As an aside, it's annoying that this doesn't make configure fail; > otherwise it wouldn't have got through my build tests. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature