* Igor Mammedov (imamm...@redhat.com) wrote:
> On Mon, 18 Dec 2017 20:13:39 +0000
> "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote:
>
> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> >
> > Remove the old update mechanism, vhost_set_memory, and the functions
> > and flags it used.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> > ---
> [...]
>
> > -
> > -static void vhost_set_memory(MemoryListener *listener,
> > - MemoryRegionSection *section,
> > - bool add)
> > -{
> [...]
>
> > - used_memslots = dev->mem->nregions;
> lost sheep?
Yes, I've moved that into the previous patch, ( vhost: Regenerate region
list from changed sections list ) so it now has:
...
dev->mem = g_realloc(dev->mem, regions_size);
dev->mem->nregions = dev->n_mem_sections;
used_memslots = dev->mem->nregions;
for (i = 0; i < dev->n_mem_sections; i++) {
...
> pls,
> see "[PATCH v2 0/2] vhost: two fixes" to get vague idea how used_memslots is
> used
Yes, that series does make it better because what confused me about the
current use of used_memslots is it seems obviously unsafe for multiple
devices.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
