On 01/10/2018 09:04 AM, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>> These are basically David's patches, with a couple changes for clarity >>> and robustness. >> >> Yes, those look fine to me. >> (Patchew seems to be annoyed at the Tracing - I can't see why) > > Stefan has explained this to me; we need to remove the spaces after the > PRIx64 macro calls in the first patch.
> +find_ram_offset_loop(uint64_t size, uint64_t candidate, uint64_t offset, > uint64_t next, uint64_t mingap) "trying size: 0x%"PRIx64 " @ 0x%"PRIx64 ," > offset: 0x%"PRIx64" next: 0x%"PRIx64 " mingap: 0x%"PRIx64 You have a misplaced ','; s/," offset/", offset/ -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
