On 09/01/2018 18:44, Peter Maydell wrote: > On 8 January 2018 at 17:49, Max Filippov <jcmvb...@gmail.com> wrote: >> Hi Peter, >> >> please pull the following batch of updates for the target/xtensa. >> Changes v1->v2: >> - Drop no longer used function option_bits_enabled. >> >> The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: >> >> Update version for v2.11.0 release (2017-12-13 14:31:09 +0000) >> >> are available in the git repository at: >> >> git://github.com/OSLL/qemu-xtensa.git tags/20180108-xtensa >> >> for you to fetch changes up to 7ffb3123b24e42a3a94e865434b4180025b9f9ca: >> >> target/xtensa: implement disassembler (2018-01-08 09:37:32 -0800) >> >> ---------------------------------------------------------------- >> target/xtensa updates: >> >> - add libisa to the xtensa target; >> - change xtensa instruction translator to use it; >> - switch existing xtensa cores to use it; >> - add support for a number of instructions: salt/saltu, const16, >> GPIO32 group, debug mode and MMU-related; >> - add disassembler for Xtensa. > > /Users/pm215/src/qemu-for-merges/target/xtensa/helper.c:63:26: error: > implicit declaration of function 'g_malloc_n' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > config->opcode_ops = g_malloc_n(opcodes, sizeof(XtensaOpcodeOps *)); > ^ > > g_malloc_n() only came in in glib 2.24, so this doesn't build on > glib 2.22 (our minimum required version).
And g_new is better anyway in this particular case. Paolo
