On Thu, Jan 11, 2018 at 10:32:37PM +0100, Marc-André Lureau wrote:
> Add #if defined(CONFIG_SPICE) in generated code, and adjust the
> qmp/hmp code accordingly.
>
> query-qmp-schema no longer reports the command/events etc as
> available when disabled at compile time.
>
> Commands made conditional:
>
> * query-spice
>
> Before the patch, the command for !CONFIG_SPICE is unregistered. It
> will fail with the same error.
>
> Events made conditional:
>
> * SPICE_CONNECTED, SPICE_INITIALIZED, SPICE_DISCONNECTED,
> SPICE_MIGRATE_COMPLETED
>
> Chardev made conditional:
>
> * spiceport, spicevmc
>
> Before and after the patch for !CONFIG_SPICE, the error is the
> same ('spiceport' is not a valid char driver name).
>
> No HMP change, the code was already conditional.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Looks good to me.
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
cheers,
Gerd
