On 01/12/2018 10:44 AM, Peter Maydell wrote:
>> if (arm_feature(env, ARM_FEATURE_NEON)) {
>> nregs += 16;
>> if (reg < nregs) {
>> - env->vfp.regs[(reg - 32) * 2] = ldfq_le_p(buf);
>> - env->vfp.regs[(reg - 32) * 2 + 1] = ldfq_le_p(buf + 8);
>> + uint64_t *q = aa32_vfp_dreg(env, (reg - 32) * 2);
>> + q[0] = ldfq_le_p(buf);
>> + q[1] = ldfq_le_p(buf + 8);
>> return 16;
>> }
>> }
>
> After reading patch 7 I came back to this one. I wonder if these two
> (which I think are the only ones) justify an aa32_vfp_qreg() ?
That does sound like a nice cleanup. I'll include that next round.
r~
