Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180116033404.31532-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH v9 00/26] tcg: generic vector operations
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20180106153730.30313-1-hpous...@reactos.org
-> patchew/20180106153730.30313-1-hpous...@reactos.org
* [new tag]
patchew/20180116033404.31532-1-richard.hender...@linaro.org ->
patchew/20180116033404.31532-1-richard.hender...@linaro.org
Switched to a new branch 'test'
318acc661a tcg/aarch64: Add vector operations
43511156d7 tcg/i386: Add vector operations
c29ad91d5c target/arm: Use vector infrastructure for aa64 orr/bic immediate
083b52d1fc target/arm: Use vector infrastructure for aa64 widening shifts
d6371398a3 target/arm: Use vector infrastructure for aa64 multiplies
25df8a60db target/arm: Use vector infrastructure for aa64 compares
57c1ab2b50 target/arm: Use vector infrastructure for aa64 constant shifts
8bfefd6b52 target/arm: Use vector infrastructure for aa64 zip/uzp/trn/xtn
ad7234c694 target/arm: Use vector infrastructure for aa64 dup/movi
6f14f6cfe8 target/arm: Use vector infrastructure for aa64 mov/not/neg
d97b762c05 target/arm: Use vector infrastructure for aa64 add/sub/logic
1ddbc6628e target/arm: Align vector registers
d7a8026fd9 tcg/optimize: Handle vector opcodes during optimize
fbeeb215e8 tcg: Add generic vector helpers with a scalar variable operand
5155c310c9 tcg: Add generic vector helpers with a scalar immediate operand
e13611c9d9 tcg: Loosen vec_gen_op* typecheck rules
03086dbc06 tcg: Add generic helpers for saturating arithmetic
ef1031a706 tcg: Add generic vector ops for extension
1629aea426 tcg: Add generic vector ops for multiplication
9788bdeec6 tcg: Add generic vector ops for comparisons
58c28e1fce tcg: Add generic vector ops for constant shifts
cc69b266cc tcg: Add generic vector ops for interleave
7c955c796b tcg: Add generic vector expanders
62b38cf8bf tcg: Standardize integral arguments to expanders
fbdd0d55ff tcg: Add types and basic operations for host vectors
3d46adc466 tcg: Allow multiple word entries into the constant pool
=== OUTPUT BEGIN ===
Checking PATCH 1/26: tcg: Allow multiple word entries into the constant pool...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#23: FILE: tcg/tcg-pool.inc.c:26:
+ int addend : 32;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#24: FILE: tcg/tcg-pool.inc.c:27:
+ int rtype : 16;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#25: FILE: tcg/tcg-pool.inc.c:28:
+ int nlong : 16;
^
total: 3 errors, 0 warnings, 156 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/26: tcg: Add types and basic operations for host vectors...
ERROR: externs should be avoided in .c files
#137: FILE: tcg/tcg-op-vec.c:37:
+extern TCGv_i32 TCGV_LOW_link_error(TCGv_i64);
ERROR: externs should be avoided in .c files
#138: FILE: tcg/tcg-op-vec.c:38:
+extern TCGv_i32 TCGV_HIGH_link_error(TCGv_i64);
ERROR: Macros with complex values should be enclosed in parenthesis
#535: FILE: tcg/tcg-opc.h:209:
+#define IMPLVEC TCG_OPF_VECTOR | IMPL(TCG_TARGET_MAYBE_vec)
WARNING: line over 80 characters
#538: FILE: tcg/tcg-opc.h:212:
+DEF(movi_vec, 1, 0, 0, TCG_OPF_VECTOR | TCG_OPF_NOT_PRESENT) /* vecl defines
const args */
ERROR: Macros with complex values should be enclosed in parenthesis
#800: FILE: tcg/tcg.h:621:
+#define TCGOP_VECL(X) (X)->param1
ERROR: Macros with complex values should be enclosed in parenthesis
#801: FILE: tcg/tcg.h:622:
+#define TCGOP_VECE(X) (X)->param2
total: 5 errors, 1 warnings, 807 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/26: tcg: Standardize integral arguments to expanders...
Checking PATCH 4/26: tcg: Add generic vector expanders...
ERROR: spaces required around that '&' (ctx:WxO)
#320: FILE: accel/tcg/tcg-runtime-gvec.c:281:
+ *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i);
^
ERROR: space prohibited after that '~' (ctx:OxW)
#320: FILE: accel/tcg/tcg-runtime-gvec.c:281:
+ *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i);
^
ERROR: spaces required around that '|' (ctx:WxO)
#331: FILE: accel/tcg/tcg-runtime-gvec.c:292:
+ *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i);
^
ERROR: space prohibited after that '~' (ctx:OxW)
#331: FILE: accel/tcg/tcg-runtime-gvec.c:292:
+ *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i);
^
ERROR: trailing whitespace
#896: FILE: tcg/tcg-op-gvec.c:464:
+ } $
total: 5 errors, 0 warnings, 2025 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/26: tcg: Add generic vector ops for interleave...
ERROR: code indent should never use tabs
#41: FILE: accel/tcg/tcg-runtime-gvec.c:318:
+^I*(TYPE *)(d + 2 * i + 0) = *(TYPE *)(a + i); \$
ERROR: code indent should never use tabs
#42: FILE: accel/tcg/tcg-runtime-gvec.c:319:
+^I*(TYPE *)(d + 2 * i + sizeof(TYPE)) = *(TYPE *)(b + i); \$
ERROR: code indent should never use tabs
#87: FILE: accel/tcg/tcg-runtime-gvec.c:364:
+^I*(TYPE *)(d + i + 0) = ae; \$
ERROR: code indent should never use tabs
#88: FILE: accel/tcg/tcg-runtime-gvec.c:365:
+^I*(TYPE *)(d + i + sizeof(TYPE)) = be; \$
total: 4 errors, 0 warnings, 571 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/26: tcg: Add generic vector ops for constant shifts...
Checking PATCH 7/26: tcg: Add generic vector ops for comparisons...
ERROR: spaces required around that '*' (ctx:WxV)
#24: FILE: accel/tcg/tcg-runtime-gvec.c:530:
+ *(TYPE *)(d + i) = *(TYPE *)(a + i) OP *(TYPE *)(b + i); \
^
ERROR: spaces required around that '==' (ctx:WxB)
#30: FILE: accel/tcg/tcg-runtime-gvec.c:536:
+ DO_CMP1(gvec_eq##SZ, vec##SZ, ==) \
^
ERROR: spaces required around that '!=' (ctx:WxB)
#31: FILE: accel/tcg/tcg-runtime-gvec.c:537:
+ DO_CMP1(gvec_ne##SZ, vec##SZ, !=) \
^
ERROR: spaces required around that '<' (ctx:WxB)
#32: FILE: accel/tcg/tcg-runtime-gvec.c:538:
+ DO_CMP1(gvec_lt##SZ, svec##SZ, <) \
^
ERROR: spaces required around that '<=' (ctx:WxB)
#33: FILE: accel/tcg/tcg-runtime-gvec.c:539:
+ DO_CMP1(gvec_le##SZ, svec##SZ, <=) \
^
ERROR: spaces required around that '<' (ctx:WxB)
#34: FILE: accel/tcg/tcg-runtime-gvec.c:540:
+ DO_CMP1(gvec_ltu##SZ, vec##SZ, <) \
^
ERROR: spaces required around that '<=' (ctx:WxB)
#35: FILE: accel/tcg/tcg-runtime-gvec.c:541:
+ DO_CMP1(gvec_leu##SZ, vec##SZ, <=)
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#223: FILE: tcg/tcg-op-gvec.c:1986:
+ && check_size_impl(oprsz, 8)
^
total: 8 errors, 0 warnings, 294 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/26: tcg: Add generic vector ops for multiplication...
Checking PATCH 9/26: tcg: Add generic vector ops for extension...
Checking PATCH 10/26: tcg: Add generic helpers for saturating arithmetic...
ERROR: spaces required around that '&' (ctx:WxO)
#64: FILE: accel/tcg/tcg-runtime-gvec.c:661:
+ if (((di ^ ai) &~ (ai ^ bi)) < 0) {
^
ERROR: space prohibited after that '~' (ctx:OxW)
#64: FILE: accel/tcg/tcg-runtime-gvec.c:661:
+ if (((di ^ ai) &~ (ai ^ bi)) < 0) {
^
ERROR: spaces required around that '&' (ctx:WxO)
#82: FILE: accel/tcg/tcg-runtime-gvec.c:679:
+ if (((di ^ ai) &~ (ai ^ bi)) < 0) {
^
ERROR: space prohibited after that '~' (ctx:OxW)
#82: FILE: accel/tcg/tcg-runtime-gvec.c:679:
+ if (((di ^ ai) &~ (ai ^ bi)) < 0) {
^
total: 4 errors, 0 warnings, 411 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/26: tcg: Loosen vec_gen_op* typecheck rules...
Checking PATCH 12/26: tcg: Add generic vector helpers with a scalar immediate
operand...
Checking PATCH 13/26: tcg: Add generic vector helpers with a scalar variable
operand...
Checking PATCH 14/26: tcg/optimize: Handle vector opcodes during optimize...
ERROR: spaces required around that ':' (ctx:VxE)
#170: FILE: tcg/optimize.c:644:
+ CASE_OP_32_64_VEC(add):
^
ERROR: spaces required around that ':' (ctx:VxE)
#171: FILE: tcg/optimize.c:645:
+ CASE_OP_32_64_VEC(mul):
^
ERROR: spaces required around that ':' (ctx:VxE)
#172: FILE: tcg/optimize.c:646:
+ CASE_OP_32_64_VEC(and):
^
ERROR: spaces required around that ':' (ctx:VxE)
#173: FILE: tcg/optimize.c:647:
+ CASE_OP_32_64_VEC(or):
^
ERROR: spaces required around that ':' (ctx:VxE)
#174: FILE: tcg/optimize.c:648:
+ CASE_OP_32_64_VEC(xor):
^
ERROR: spaces required around that ':' (ctx:VxE)
#183: FILE: tcg/optimize.c:713:
+ CASE_OP_32_64_VEC(sub):
^
ERROR: spaces required around that ':' (ctx:VxE)
#206: FILE: tcg/optimize.c:744:
+ CASE_OP_32_64_VEC(xor):
^
ERROR: spaces required around that ':' (ctx:VxE)
#215: FILE: tcg/optimize.c:761:
+ CASE_OP_32_64_VEC(andc):
^
ERROR: spaces required around that ':' (ctx:VxE)
#224: FILE: tcg/optimize.c:769:
+ CASE_OP_32_64_VEC(orc):
^
ERROR: spaces required around that ':' (ctx:VxE)
#246: FILE: tcg/optimize.c:807:
+ CASE_OP_32_64_VEC(add):
^
ERROR: spaces required around that ':' (ctx:VxE)
#247: FILE: tcg/optimize.c:808:
+ CASE_OP_32_64_VEC(sub):
^
ERROR: spaces required around that ':' (ctx:VxE)
#248: FILE: tcg/optimize.c:809:
+ CASE_OP_32_64_VEC(or):
^
ERROR: spaces required around that ':' (ctx:VxE)
#249: FILE: tcg/optimize.c:810:
+ CASE_OP_32_64_VEC(xor):
^
ERROR: spaces required around that ':' (ctx:VxE)
#250: FILE: tcg/optimize.c:811:
+ CASE_OP_32_64_VEC(andc):
^
ERROR: spaces required around that ':' (ctx:VxE)
#268: FILE: tcg/optimize.c:824:
+ CASE_OP_32_64_VEC(and):
^
ERROR: spaces required around that ':' (ctx:VxE)
#269: FILE: tcg/optimize.c:825:
+ CASE_OP_32_64_VEC(orc):
^
ERROR: spaces required around that ':' (ctx:VxE)
#279: FILE: tcg/optimize.c:1039:
+ CASE_OP_32_64_VEC(and):
^
ERROR: spaces required around that ':' (ctx:VxE)
#280: FILE: tcg/optimize.c:1040:
+ CASE_OP_32_64_VEC(mul):
^
ERROR: spaces required around that ':' (ctx:VxE)
#290: FILE: tcg/optimize.c:1055:
+ CASE_OP_32_64_VEC(or):
^
ERROR: spaces required around that ':' (ctx:VxE)
#291: FILE: tcg/optimize.c:1056:
+ CASE_OP_32_64_VEC(and):
^
ERROR: spaces required around that ':' (ctx:VxE)
#302: FILE: tcg/optimize.c:1068:
+ CASE_OP_32_64_VEC(andc):
^
ERROR: spaces required around that ':' (ctx:VxE)
#303: FILE: tcg/optimize.c:1069:
+ CASE_OP_32_64_VEC(sub):
^
ERROR: spaces required around that ':' (ctx:VxE)
#304: FILE: tcg/optimize.c:1070:
+ CASE_OP_32_64_VEC(xor):
^
ERROR: spaces required around that ':' (ctx:VxE)
#313: FILE: tcg/optimize.c:1084:
+ CASE_OP_32_64_VEC(mov):
^
total: 24 errors, 0 warnings, 296 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/26: target/arm: Align vector registers...
Checking PATCH 16/26: target/arm: Use vector infrastructure for aa64
add/sub/logic...
Checking PATCH 17/26: target/arm: Use vector infrastructure for aa64
mov/not/neg...
Checking PATCH 18/26: target/arm: Use vector infrastructure for aa64 dup/movi...
Checking PATCH 19/26: target/arm: Use vector infrastructure for aa64
zip/uzp/trn/xtn...
Checking PATCH 20/26: target/arm: Use vector infrastructure for aa64 constant
shifts...
Checking PATCH 21/26: target/arm: Use vector infrastructure for aa64 compares...
Checking PATCH 22/26: target/arm: Use vector infrastructure for aa64
multiplies...
Checking PATCH 23/26: target/arm: Use vector infrastructure for aa64 widening
shifts...
Checking PATCH 24/26: target/arm: Use vector infrastructure for aa64 orr/bic
immediate...
Checking PATCH 25/26: tcg/i386: Add vector operations...
Checking PATCH 26/26: tcg/aarch64: Add vector operations...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
