Am 11.01.2018 um 20:52 hat Kevin Wolf geschrieben: > This series implements a minimal QMP command that allows to create an > image format on a given block node. The interface is still going to > change to some kind of an async command (possibly a block job), so I > prefixed x- for now. > > At this point, I'm mostly interested in comments about > BlockdevCreateOptions in the schema, the .bdrv_co_create callback and > the way that legacy .bdrv_create is implemented in qcow2 now. > > It looks to me as if we will have to keep .bdrv_create in addition to > the new .bdrv_co_create for a while in all drivers, where the > implementation of .bdrv_create would call .bdrv_co_create like this > series does it for qcow2. We'll only be able to drop the old interface > after deprecating and eventually removing all of the driver-specific > compatibility work that remains. The example of qcow2 shows that the > "translation" from old to new is managable, but there are a few > differences.
Peter? Eric? Any opinions so far? Kevin
