On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: > > > On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote: > > Hi, > > > > This series is to be clearer about which upstream version we are using. > > > > All "FROM distrib:latest" entries have now been removed and replaced by > > explicit "FROM distrib:version" ones. > > > > To keep backward compatibility, a warning is displayed to the user, > > suggesting which correct base image to use. > > > > To be consistent, we remove the deprecated images of the "make docker" > > output. > > Changing image names when a new release comes out is not maintainable for > Fedora and Ubuntu because of the fast pace. Therefore I prefer Paolo's > simple patch.
The flipside is that if we release QEMU 2.12 with fedora:27, then for as long as the 2.12 stable branch exists, dockers tests run on that branch will have a consistent target and will be unlikely to break. If we use fedora:latest, then every time a new Fedora comes out there's non-trivial chance that docker builds on all the stable branches will all break due to some new glibc change. Sticking with explicit named versions is a big win in this respect IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|