On 2017-11-23 03:08, Max Reitz wrote: > This series fixes the qemu-iotests for qcow, vmdk, qcow2 v2 and qcow2 v3 > with refcount_bits=1. > > Patches 1 and 2 contain real fixes (not urgent, though, so no need to > hurry for 2.11--we can take them into 2.11 if we want to, but there is > no absolute need for them). > > Patches 3 and 4 add blkdebug events to qcow and vmdk so iotests 020 can > work with them even after patch 10. > > Patches 5 and 6 are general "fixes" for the iotests infrastructure. > > Patches 7, 8, and 9 add some missing skips under certain circumstances > to tests that need them. > > The rest of this series (patches 10 through 17) actually fix tests so > they work for the formats and options mentioned above. > > (Fun fact: qcow v1 wasn't broken before this series. But it would be > broken by patch 10 if I didn't include patch 3. That is why I > mentioned it above.) > > > Personal note: I should really stop writing bash tests, at least as > soon as there is QMP involved. While working on this series I got > sidetracked a bit and actually wrote some iotests.py functions that may > come in handy next time I write a test. > > (I hate to write Python tests because the boilerplate seems so large and > the debugging is so hard. But there is test 194 which shows that it is > possible to write simple bash-like tests as well--and that is how I > should probably write tests from now on.) > > > Max Reitz (17): > block/vmdk: Fix , instead of ; at end of line > qcow2: No persistent dirty bitmaps for compat=0.10 > block/qcow: Add blkdebug events > block/vmdk: Add blkdebug events > iotests: Fix _img_info for backslashes > iotests: Drop format-specific in _filter_img_info > iotests: Forbid 020 for non-file protocols > iotests: Skip 103 for refcount_bits=1 > iotests: Disable some tests for compat=0.10 > iotests: Fix 020 for vmdk > iotests: Fix 051 for compat=0.10 > iotests: Fix 059's reference output > iotests: Fix 067 for compat=0.10 > iotests: Make 089 compatible with compat=0.10 > iotests: Make 184 image-less > iotests: Make 191 work with qcow2 options > iotests: Filter compat-dependent info in 198
Thanks all the reviewers, I've applied all patches except for patch 9 to my block branch. Max
signature.asc
Description: OpenPGP digital signature
