On 01/16/2018 05:18 PM, Shaun Reitan wrote: > This patch replaces the patch I sent yesturday. This one fixes > a bug in my original code as well as corrects a few styling > issues. Hopfully this one comes out correct! Sorry for the > inconvienece.
This paragraph belongs...
>
> When currently using -netdev bridge or -netdev tap with a helper
> you are unable to set an ifname. This patch adds that ability so
> that you can now specify an ifname.
>
> Signed-off-by: Shaun Reitan <shaun.rei...@ndchost.com>
> ---
...here, after the --- separator. It is useful for reviewers reading
the list, but pointless in the git log a year from now.
> net/tap.c | 33 ++++++++++++++++++++++++---------
> qapi/net.json | 1 +
> qemu-bridge-helper.c | 11 +++++++++--
> qemu-options.hx | 2 +-
> 4 files changed, 35 insertions(+), 12 deletions(-)
> +++ b/qapi/net.json
> @@ -402,6 +402,7 @@
> { 'struct': 'NetdevBridgeOptions',
> 'data': {
> '*br': 'str',
> + '*ifname': 'str',
Missing documentation (including a '(since 2.12)' tag) of the new field.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
