On Thu, 18 Jan 2018 13:49:25 +0000 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 18 January 2018 at 13:45, Igor Mammedov <imamm...@redhat.com> wrote: > > On Thu, 18 Jan 2018 13:36:40 +0000 > > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > >> On 18 January 2018 at 13:34, Igor Mammedov <imamm...@redhat.com> wrote: > >> > and renaming > >> > > >> > TARGET_DEFAULT_CPU_TYPE to USERONLY_DEFAULT_CPU_TYPE > >> > > >> > but I'd still keep it within $ARCH/cpu.h so we won't > >> > have to create a bunch of new linux-user/$ARCH/target_elf.h > >> > files just for that and duplicate it to bsd-user/$ARCH/target_elf.h > >> > >> We already have linux-user/$ARCH/target_cpu.h, which is exactly > >> for this kind of define. > > we don't have it for bsd-user though and it would be > > code duplication to add such. > > Using $ARCH/cpu.h seems to be a better fit for sharing > > default across liux/bsd-user. > > Yes, bsd-user is a bit unmaintained and behind linux-user in > its structuring. I don't mind bsd-user being a bit of a mess, > but I don't want problems in bsd-user to cause us to put code > where it shouldn't be in other parts of the codebase. (It's > not inherently the case that "best CPU choice for Linux user" > is the same as "best CPU choice for bsd-user" either.) Ok, if there isn't objections wrt above mentioned code duplication in *-user, I surely can implement it as far as I can remove cpu_model along with it. > > thanks > -- PMM
