On Thu, Jan 18, 2018 at 10:09:09AM +0000, Peter Maydell wrote: > On 16 January 2018 at 17:46, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > Changes from v1: > > 32 build fix > > vhost-user-blk build fix > > s390 qom fix > > include mem slot limit fix > > > > The following changes since commit f521eeee3bd060b460c99e605472b7e03967db43: > > > > Merge remote-tracking branch > > 'remotes/juanquintela/tags/migration/20180115' into staging (2018-01-15 > > 13:17:47 +0000) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to 1d9dc60062ae05375c080bbe2db5a5c3c4f495bc: > > > > vhost: used_memslots refactoring (2018-01-16 18:52:03 +0200) > > > > ---------------------------------------------------------------- > > pc, pci, virtio: features, fixes, cleanups > > > > A bunch of fixes, cleanus and new features all over the place. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > Hi -- this pullreq triggers a lot of alignment warnings for vhost > in the clang runtime sanitizer:
Are these build or make check errors? > /home/petmay01/linaro/qemu-for-merges/hw/virtio/vhost-user.c:325:22: > runtime error: member access within misaligned address 0x7fff9c7bdf1c > for type 'VhostUserMemory' (aka > 'struct VhostUserMemory'), which requires 8 byte alignment > 0x7fff9c7bdf1c: note: pointer points here > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 85 54 c8 a8 5c 55 > 00 00 01 cf 9f ac 5c 55 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/virtio/vhost-user.c:325:22: > runtime error: store to misaligned address 0x7fff9c7bdf1c for type > 'uint32_t' (aka 'unsigned int'), w > hich requires 8 byte alignment > 0x7fff9c7bdf1c: note: pointer points here > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 85 54 c8 a8 5c 55 > 00 00 01 cf 9f ac 5c 55 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/virtio/vhost-user.c:335:22: > runtime error: member access within misaligned address 0x7fff9c7bdf1c > for type 'VhostUserMemory' (aka > 'struct VhostUserMemory'), which requires 8 byte alignment > 0x7fff9c7bdf1c: note: pointer points here > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 85 54 c8 a8 5c 55 > 00 00 01 cf 9f ac 5c 55 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/virtio/vhost-user.c:335:22: > runtime error: load of misaligned address 0x7fff9c7bdf1c for type > 'uint32_t' (aka 'unsigned int'), wh > ich requires 8 byte alignment > 0x7fff9c7bdf1c: note: pointer points here > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 85 54 c8 a8 5c 55 > 00 00 01 cf 9f ac 5c 55 00 00 > ^ > > (and more) > > thanks > -- PMM