On Tue, Jan 23, 2018 at 05:08:08PM +0100, Marc-Andre Lureau wrote: > Hi > > On Tue, Jan 23, 2018 at 4:38 PM, Daniel P. Berrange <berra...@redhat.com> > wrote: > > On Tue, Jan 16, 2018 at 03:16:52PM +0100, Paolo Bonzini wrote: > >> From: Marc-André Lureau <marcandre.lur...@redhat.com> > >> > >> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu > >> specific). > >> > >> Use --quiet to silence make 'is up to date' message. > >> > >> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > >> Tested-by: Eric Blake <ebl...@redhat.com> > >> Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > >> Message-Id: <20180104160523.22995-3-marcandre.lur...@redhat.com> > >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > >> --- > >> Makefile | 2 +- > >> rules.mak | 2 ++ > >> 2 files changed, 3 insertions(+), 1 deletion(-) > > > > After applying it when you run 'make install' absolutely nothing is > > displayed, but it none the less does work. This is very misleading > > to devs who thing nothing is being installed... > > Right, you would need V=1 now > > > Either this needs reverting, or we need to re-write the 'install' target > > so that it generates messages of whats being installed. Perhaps something > > like this > > > > Make sense to me, could you send a former patch for review?
When I looked at this more, I became concerned that I would inevitably miss places which need updating, as our makefiles as huge & have many targets potentially affected by this. So I took the former approach, with a small tweak to silence "is up to date" messages Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
