On 01/23/2018 10:47 AM, Daniel P. Berrange wrote: > This reverts commit 42a77f1ce4934b243df003f95bda88530631387a. > > The primary intention of this change was to silence messages > like > > make[1]: '/home/berrange/src/virt/qemu/capstone/libcapstone.a' is up to > date. > > which we get when calling make recursively with explicit > targets. > > The problem is that this change affected every make target, > not merely the targets that triggered these "is up to date" > messages. As a result any targets that were not invoking > commands via "$(call quiet-command ...)" suddenly become > silent. This is particularly bad for "make install" which > now appears todo nothing. > > Rather than go through every make rule and try to identify > places where we now need to explicitly print a message to > show work taking place, just revert the change. > > To address the original problem of silencing "is up to date" > messages, we simply add --quiet to the SUBDIR_MAKEVARS > variable, so it only affects us on recursive make calls.
As for solving the original intended issue, this patch silences the message about libcapstone, and reverting back to a known state is more conservative, so I'm okay with this going in. Tested-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
