BALATON Zoltan <bala...@eik.bme.hu> writes: > On Tue, 30 Jan 2018, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to target/s390x/gen-features.c manually reverted, and blank lines >> around deletions collapsed. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> [...] >> diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c >> index 17aa930e39..a5d1776756 100644 >> --- a/hw/ide/sii3112.c >> +++ b/hw/ide/sii3112.c >> @@ -12,6 +12,7 @@ >> * http://wiki.osdev.org/User:Quok/Silicon_Image_Datasheets >> */ >> >> +#include "qemu/osdep.h" >> #include <qemu/osdep.h> >> #include <hw/ide/pci.h> >> #include "trace.h" > > This is wrong. I've sent a patch instead to change angle brackets to > quotes for these two includes. This wasn't catched either by > checkpatch nor review though so maybe it could be added to checkpatch > if quotes are the preferred style for these includes.
Good catch! There's more than these two in the tree. I'll stick in a suitable cleanup patch.
