On 31.01.2018 15:48, Markus Armbruster wrote: > System headers should be included with <...>, our own headers with > "...". Offenders tracked down with an ugly, brittle and probably > buggy Perl script. Previous iteration was commit a9c94277f0. > > Put the cleaned up system header includes first, except for the ones > the next commit will delete.
That's a little bit of code churn ... why not delete them here immediately, or simply ignore these headers here and just delete them in the next patch? > While there, separate #include from file comment with a blank line, > > Signed-off-by: Markus Armbruster <[email protected]> > --- [...] > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index 0570f597ec..9968974fbe 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -13,8 +13,8 @@ > */ > > While you're at it, remove one of the two blank lines? > -#include "inttypes.h" > -#include "stdio.h" > +#include <inttypes.h> > +#include <stdio.h> > #include "cpu_features_def.h" Above remarks are just nits, anyway patch looks fine, so: Reviewed-by: Thomas Huth <[email protected]>
