On 08.02.2018 16:19, Eric Blake wrote: > > Missing a documentation line that mentions when the enum grew. Also, has > a conflict with this other proposed addition, which demonstrates what > the documentation should look like (should be easy to resolve, though): > https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg01986.html > Good pointer, thanks. So the enum conflict would be resolved on a first-to-ack base? > >> ## >> +# @CpuInfoS390State: >> +# >> +# An enumeration of cpu states that can be assumed by a virtual >> +# S390 CPU >> +# >> +# Since: 2.12 >> +## >> +{ 'enum': 'CpuInfoS390State', >> + 'data': [ 'uninitialized', 'stopped', 'check_stop', 'operating', >> 'load' ] } >> + > > Is there a consistency reason for naming this 'check_stop', or can we go > with our preference for using dash 'check-stop'? No specific reason, I've based that on the definitions previously in target/s390x/cpu.h, same thing for cpu-state. Will update. > >> +## >> +# @CpuInfoS390: >> +# >> +# Additional information about a virtual S390 CPU >> +# >> +# @cpu_state: the CPUs state >> +# >> +# Since: 2.12 >> +## >> +{ 'struct': 'CpuInfoS390', 'data': { 'cpu_state': 'CpuInfoS390State' } } > > Likewise for 'cpu-state' >
-- Regards, Viktor Mihajlovski
