On 13 February 2018 at 12:51, Abdallah Bouassida <abdallah.bouass...@lauterbach.com> wrote:
>> Hi. I tried applying this patch to review it, but unfortunately your >> email client has made a complete mess of it. In particular: >> * it is wrapping long lines >> * it is converting all the leading space characters to unicode >> non-breaking space characters >> >> which means that it won't apply. Can you resend using something that >> doesn't mangle plaintext, please? > > Hi Peter, > > Thanks for the review! > I'm sorry, I wasn't aware of such a wrapping problem. So, here it is the > patch as > a plain text email. > > > Best regards, > Abdallah > > gdbstub.c | 18 +++++++++++ > include/qom/cpu.h | 3 ++ > target/arm/cpu.c | 3 ++ > target/arm/cpu.h | 18 +++++++++++ > target/arm/gdbstub.c | 87 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > target/arm/gdbstub64.c | 25 +++++++++++++++ > target/arm/helper.c | 3 +- > 7 files changed, 155 insertions(+), 2 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index f1d5148..f54053f 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -670,10 +670,20 @@ static const char *get_feature_xml(const char *p, > const char **newp, I'm afraid your email client is still wrapping long lines, as you can see here. It is also doing the space-to-unicode-non-breaking-space transformation. It looks like you're using Thunderbird, in which case this might help: https://www.kernel.org/doc/html/v4.11/process/email-clients.html#thunderbird-gui It suggests disabling sending of format=flowed and wrapping of long lines for patch emails. Alternatively if you plan to send more patch mails in future you might look into configuring the git-send-email command. thanks -- PMM