Hi Sergei, On 02/15/2018 03:21 PM, Sergei Trofimovich wrote: > On Thu, 15 Feb 2018 14:35:39 -0300 > Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > >> #else >> +#include <capstone/capstone.h> > > I think it's incorrect. 'pkg-config' already reports 'capstone/' path: > $ pkg-config --cflags capstone > -I/usr/include/capstone
Glad to hear feedback from a Gentoo developer! Ok so the problem Haiku only, which we don't support anymore. > > $ ls /usr/include/capstone/capstone.h > /usr/include/capstone/capstone.h > > Thus I would guess > #include <capstone.h> > is still correct for system include path as well (contradicts the example). My guess is the example is probabilisticly safer for people compiling without using 'pkg-config'. > qemu just needs to use 'pkg-config' to discover the include path and > libs. Maybe new capstone release has different pkgconfig setup? I think it is safer to drop this patch. Thanks for your review! Phil.
