On Tue, Feb 20, 2018 at 06:43:22PM +0000, Peter Maydell wrote: > I just noticed that we seem to have acquired another git > submodule that isn't pointing to a qemu.org git url: > > [submodule "roms/seabios-hppa"] > path = roms/seabios-hppa > url = git://github.com/hdeller/seabios-hppa.git > > Jeff, could we set up so we can mirror this repo on qemu.org? > Then we can send a patch to update the .gitmodules to point to it. >
Yes, of course... Although Paolo has suggested making it a branch of the existing SeaBIOS repo instead. But I can go ahead and get the clone setup, in case we go that route. > (There's also a patchset on list that wants to add a > submodule for git://github.com/zbalaton/u-boot-sam460ex > but I don't know if that will go in or not yet. Should > we insist that we set up the mirror first for new > submodules, or allow them in and fix things up after? > By default we're doing the latter at the moment; the > former seems cleaner but makes it more painful for > contributors to get things added which need new > submodules.) > My thought: while not as clean, I think it makes sense in general to allow a patchset in first, and then switch it over later. If we require a mirror on qemu.org first, then we could end up creating mirrors that are never used, if patches are rejected for some other reason and the submodule goes unused. By doing the mirror later, the patchset goes through normal review and the submodule is committed, and so we know for sure at that point we want the mirror. -Jeff
