On Tue 20 Feb 2018 11:24:58 PM CET, Eric Blake wrote: > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index d46b69d7f34..3fefeb3dc50 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -2310,8 +2310,8 @@ write_refblocks: > on_disk_refblock = (void *)((char *) *refcount_table + > refblock_index * s->cluster_size); > > - ret = bdrv_write(bs->file, refblock_offset / BDRV_SECTOR_SIZE, > - on_disk_refblock, s->cluster_sectors); > + ret = bdrv_pwrite(bs->file, refblock_offset, > + on_disk_refblock, s->cluster_size);
It looks like the second line is not properly indented. I think you can also move on_disk_refblock to the previous line. Otherwise the patch looks good. Reviewed-by: Alberto Garcia <be...@igalia.com> Berto