On Wed, Jan 24, 2018 at 01:39:52PM +0800, Peter Xu wrote:
> Having "allow-oob" to true for a command does not mean that this command
> will always be run in out-of-band mode. The out-of-band quick path will
> only be executed if we specify the extra "run-oob" flag when sending the
> QMP request:
>
> { "execute": "command-that-allows-oob",
> "arguments": { ... },
> "control": { "run-oob": true } }
>
> The "control" key is introduced to store this extra flag. "control"
> field is used to store arguments that are shared by all the commands,
> rather than command specific arguments. Let "run-oob" be the first.
>
> Note that in the patch I exported qmp_dispatch_check_obj() to be used to
> check the request earlier, and at the same time allowed "id" field to be
> there since actually we always allow that.
>
> Signed-off-by: Peter Xu <pet...@redhat.com>
> ---
> include/qapi/qmp/dispatch.h | 2 ++
> monitor.c | 84
> ++++++++++++++++++++++++++++++++++++++++-----
> qapi/qmp-dispatch.c | 32 ++++++++++++++++-
> trace-events | 2 ++
> 4 files changed, 110 insertions(+), 10 deletions(-)Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
