On 13.01.2011, at 17:39, Anthony Liguori wrote: > On 01/13/2011 10:14 AM, Avi Kivity wrote: >> On 01/13/2011 05:52 PM, Anthony Liguori wrote: >>> >>> /* host->guest, sent before any other events */ >>> typedef struct qemu_pvtablet_init { >>> uint32_t res_x; /* x axis resolution */ >>> uint32_t res_y; /* y axis resolution */ >>> uint32_t features; /* qemu_pvtablet_features */ >> >> uint32_t available_buttons; /* bitmask */ > > Yes, I had intended to do that but left it out. > > Should it be a bitmask or just a button count? Buttons really have no > standard meaning so usually a button count is sufficient.
Some random thoughts: * multitouch capabilities would be good to design in a mouse protocol for 2011, so having say 16 x/y pairs would be better * on mac os at least scrolling is not done by pressing virtual buttons, but by having a separate scroll interface that knows about velocity and such - maybe worth adding that to the protocol from the beginning too. Alex