Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Subject: [Qemu-devel] [PATCHv3 00/12] macio: remove legacy macio_init() function Message-id: 20180228203243.1413-1-mark.cave-ayl...@ilande.co.uk === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180228203243.1413-1-mark.cave-ayl...@ilande.co.uk -> patchew/20180228203243.1413-1-mark.cave-ayl...@ilande.co.uk Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 'capstone' Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (git://git.qemu.org/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (git://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (git://git.qemu.org/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered for path 'roms/vgabios' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'fa981320a1e0968d6fc1b8de319723ff8212b337' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out '0600d3ae94f93efd10fc6b3c7420a9557a3a1670' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '54d959d97fb331708767b2fd4a878efd2bbc41bb' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out 'f3c7e44c70254975df2a00af39701eafbac4d471' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out '63451fca13c75870e1703eb3e20584d91179aebc' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '649e6202b8d65d46c69f542b1380f840fbe8ab13' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/vgabios'... Submodule path 'roms/vgabios': checked out '19ea12c230ded95928ecaef0db47a82231c2e485' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 172de12 macio: remove macio_init() function 0e9b5f9 macio: move setting of CUDA timebase frequency to macio_common_realize() cb79b98 mac_newworld: use object link to pass OpenPIC object to macio 9042b9c openpic: move OpenPIC state and related definitions to openpic.h dbb8ece openpic: move KVM-specific declarations into separate openpic_kvm.h file 62cc211 mac_oldworld: use object link to pass heathrow PIC object to macio 1fe3633 macio: move macio related structures and defines into separate macio.h file 2e9a6f0 heathrow: change heathrow_pic_init() to return the heathrow device 6dbf45d heathrow: convert to trace-events b109c28 heathrow: QOMify heathrow PIC 5ee002a macio: move ESCC device within the macio device 4d426b1 macio: embed DBDMA device directly within macio === OUTPUT BEGIN === Checking PATCH 1/12: macio: embed DBDMA device directly within macio... Checking PATCH 2/12: macio: move ESCC device within the macio device... Checking PATCH 3/12: heathrow: QOMify heathrow PIC... Checking PATCH 4/12: heathrow: convert to trace-events... Checking PATCH 5/12: heathrow: change heathrow_pic_init() to return the heathrow device... Checking PATCH 6/12: macio: move macio related structures and defines into separate macio.h file... Checking PATCH 7/12: mac_oldworld: use object link to pass heathrow PIC object to macio... Checking PATCH 8/12: openpic: move KVM-specific declarations into separate openpic_kvm.h file... Checking PATCH 9/12: openpic: move OpenPIC state and related definitions to openpic.h... ERROR: "foo * bar" should be "foo *bar" #249: FILE: include/hw/ppc/openpic.h:57: +#define RAVEN_DBL_IRQ (RAVEN_IPI_IRQ + (RAVEN_MAX_CPU * RAVEN_MAX_IPI)) total: 1 errors, 0 warnings, 353 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 10/12: mac_newworld: use object link to pass OpenPIC object to macio... Checking PATCH 11/12: macio: move setting of CUDA timebase frequency to macio_common_realize()... Checking PATCH 12/12: macio: remove macio_init() function... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org