On Thu, Mar 01, 2018 at 04:03:44PM +0000, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:27PM +0800, Peter Xu wrote: > > The old incoming migration is running in main thread and default > > gcontext. With the new qio_channel_add_watch_full() we can now let it > > run in the thread's own gcontext (if there is one). > > > > Currently this patch does nothing alone. But when any of the incoming > > migration is run in another iothread (e.g., the upcoming migrate-recover > > command), this patch will bind the incoming logic to the iothread > > instead of the main thread (which may already get page faulted and > > hanged). > > > > RDMA is not considered for now since it's not even using the QIO watch > > framework at all. > > > > CC: Juan Quintela <quint...@redhat.com> > > CC: Dr. David Alan Gilbert <dgilb...@redhat.com> > > CC: Laurent Vivier <lviv...@redhat.com> > > Signed-off-by: Peter Xu <pet...@redhat.com> > > --- > > migration/exec.c | 9 ++++----- > > migration/fd.c | 9 ++++----- > > migration/socket.c | 10 +++++----- > > 3 files changed, 13 insertions(+), 15 deletions(-) > > This should probably just be in a separate series, since it does nothing > on its own, and nothing following in this series touches migration at all.
It was trying to solve all problems related to QIO+context, and migration is just one user of it. But sure I can postpone this patch to the postcopy recovery series. Thanks, -- Peter Xu