On Thu, Mar 01, 2018 at 04:01:38PM +0000, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:37PM +0800, Peter Xu wrote: > > This patch allows the socket chardev async connection be setup with > > non-default gcontext. We do it by postponing the setup to machine done, > > since until then we can know which context we should run the async > > operation on. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > --- > > chardev/char-socket.c | 17 ++++++++++++++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > I don't like this as it is special casing behaviour wrt GMainContext > only the the case where the chardev is configured as a client with > non-blocking connect. So any code that uses chardevs and wants to > set a different GMainContext may or may not work, depending on > whether the user gave the ',wait' option to the chardev. I'm struggling > to see why this is really needed at all.
Not sure whether I fully got your point, but IMHO when "wait" is there we should be perfectly fine too if with all the TLS/TELNET patches in the this series. And for sure this patch only solves the problem when "wait" is specified. Or say, with this series, all configuration of chardev _should_ work with non-default context now. If not, then I must have missed something else (which may be possible), then I would be very glad that anyone can give me a hint on where. Thanks, -- Peter Xu
