On Fri, Mar 02, 2018 at 11:58:52AM +0800, Peter Xu wrote: > On Thu, Mar 01, 2018 at 10:47:17AM +0000, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > > > Three functions are abstracted from the old code: > > > > > > - qio_net_listener_source_add(): create one source for listener > > > - qio_net_listener_sources_clear(): unset existing net lister sources > > > - qio_net_listener_sources_update(): setup all sources for listener > > > > > > Use them where possible. > > > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > > --- > > > io/net-listener.c | 82 > > > +++++++++++++++++++++++++++---------------------------- > > > 1 file changed, 41 insertions(+), 41 deletions(-) > > > > This patch can be dropped since nothing else in the series now > > depends on it. > > Do you think it's still acceptable even as a cleanup? Thanks,
I don't think it really adds value over what's there already. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|