On 01/03/2018 11:33, Liu, Yi L wrote: > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops) > +{ > + if (dev) { > + dev->sva_ops = ops; > + } > + return; > +} > +
Better: { assert(ops && !dev->sva_ops); dev->sva_ops = ops; }
On 01/03/2018 11:33, Liu, Yi L wrote: > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops) > +{ > + if (dev) { > + dev->sva_ops = ops; > + } > + return; > +} > +
Better: { assert(ops && !dev->sva_ops); dev->sva_ops = ops; }