On 02/15/2018 07:54 PM, Alistair Francis wrote: > On Thu, Feb 15, 2018 at 2:13 PM, Philippe Mathieu-Daudé <f4...@amsat.org> > wrote: >> returning sd_illegal, since they are not implemented. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- >> hw/sd/sd.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/hw/sd/sd.c b/hw/sd/sd.c >> index 30acd04ad7..0457f5214b 100644 >> --- a/hw/sd/sd.c >> +++ b/hw/sd/sd.c >> @@ -1551,6 +1551,17 @@ static sd_rsp_type_t sd_app_command(SDState *sd, >> } >> break; >> >> + case 18: /* Reserved for SD security applications */ >> + case 25: >> + case 26: >> + case 38: >> + case 43 ... 49: >> + /* Refer to the "SD Specifications Part3 Security Specification" for >> + * information about the SD Security Features */ > > The */ should be on a new line.
Thanks Peter for fixing this :) > > Otherwise: > > Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> Thanks! > > Alistair > >> + qemu_log_mask(LOG_UNIMP, "SD: CMD%i Security not implemented\n", >> + req.cmd); >> + return sd_illegal; >> + >> default: >> /* Fall back to standard commands. */ >> return sd_normal_command(sd, req); >> -- >> 2.16.1 >> >>
