On 02/22/2018 10:02 AM, Peter Maydell wrote: > On 15 February 2018 at 22:05, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Commit message talks about a function but the patch doesn't > add any new functions ? (Also, sentences should start with
I suppose I mistaken the commit message when I rebased, this message belongs to the previous commit. > a capital letter and end with a full stop, please.) Got it! > Otherwise > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Thanks!
